[S] Change in flashrom[master]: cli_classic: move version output outside of parsing - flashrom-gerrit

27 Apr 2023


      Attention is currently required from: Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66535 )
Change subject: cli_classic: move version output outside of parsing
......................................................................
Patch Set 2:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/66535/comment/2a25fb2a_77839c3d 
PS2, Line 817: /* print_version() is always called during startup. */
Is this comment saying the version option is not needed, because version is always printed no matter what?
I am wondering... is there a way to optimise the situation
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66535
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1e6849a734480deed030191fa5e7066b1da4f23a
Gerrit-Change-Number: 66535
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Thu, 27 Apr 2023 10:53:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment