Attention is currently required from: Felix Singer, Light, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/62747
to look at the new patch set (#14).
Change subject: flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc ......................................................................
flashrom.c, sfdp.c: Initialize dynamically allocated memory using calloc
In flashrom_image_write variables curcontents and oldcontents are dynamically allocated using malloc. These could remain uninitialized and when later used in need_erase could result in undefined behaviour. Similar reasoning for variables hbuf, hdrs, tbuf in function prob_spi_sfdp.
So allocate them using calloc to initialize them to zeroes. Also, copy "FLASHROM BUG!" to detect future bugs.
Change-Id: I6b9269129968fb3b55b0d2a2e384c8a1aeba43ab Signed-off-by: Aarya Chaumal aarya.chaumal@gmail.com --- M flashrom.c M sfdp.c 2 files changed, 9 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/47/62747/14