Attention is currently required from: PoroCYon, Angel Pons, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73582 )
Change subject: flashchips: Add Macronix MX25Vxx35F support ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: Seems good, only minor things. Can you split the patch into three to have one for each new flashchip. Also adding a link to the corresponding datasheets in the commit message.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/73582/comment/1e58ce5f_639d6e87 PS1, Line 9671: { : .eraseblocks = { {2 * 1024 * 1024, 1} }, : .block_erase = SPI_BLOCK_ERASE_60, : } The chip erase can also be performed with `SPI_BLOCK_ERASE_C7`
Page 49, Figure 29 in the datasheet.