Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33670
Change subject: Makefile: Enable -Wmissing-prototypes ......................................................................
Makefile: Enable -Wmissing-prototypes
Change-Id: Ia2ea3dee11e505c04a9e7956417615e39d511886 Signed-off-by: Jacob Garber jgarber1@ualberta.ca --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/70/33670/1
diff --git a/Makefile b/Makefile index e08a3f6..7a21d12 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,7 @@ DIFF = diff PREFIX ?= /usr/local MANDIR ?= $(PREFIX)/share/man -CFLAGS ?= -Os -Wall -Wshadow +CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes EXPORTDIR ?= . RANLIB ?= ranlib PKG_CONFIG ?= pkg-config
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33670 )
Change subject: Makefile: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33670 )
Change subject: Makefile: Enable -Wmissing-prototypes ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33670 )
Change subject: Makefile: Enable -Wmissing-prototypes ......................................................................
Makefile: Enable -Wmissing-prototypes
Change-Id: Ia2ea3dee11e505c04a9e7956417615e39d511886 Signed-off-by: Jacob Garber jgarber1@ualberta.ca Reviewed-on: https://review.coreboot.org/c/flashrom/+/33670 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Nico Huber nico.h@gmx.de --- M Makefile 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved HAOUAS Elyes: Looks good to me, approved
diff --git a/Makefile b/Makefile index e08a3f6..7a21d12 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,7 @@ DIFF = diff PREFIX ?= /usr/local MANDIR ?= $(PREFIX)/share/man -CFLAGS ?= -Os -Wall -Wshadow +CFLAGS ?= -Os -Wall -Wshadow -Wmissing-prototypes EXPORTDIR ?= . RANLIB ?= ranlib PKG_CONFIG ?= pkg-config
-
HAOUAS Elyes (Code Review) -
Jacob Garber (Code Review)
-
Nico Huber (Code Review)