Mario Limonciello has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/36069 )
Change subject: Correct the pkgconfig generated file naming ......................................................................
Correct the pkgconfig generated file naming
The typical convention is to not use the `lib` prefix (ie `libfoo`) but instead to just use foo.
Change-Id: I5ab46418e2a1708d5c11970f1e56250f2adb7d70 Signed-off-by: Mario Limonciello mario.limonciello@dell.com --- M meson.build 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/69/36069/1
diff --git a/meson.build b/meson.build index f63e7bf..b63875e 100644 --- a/meson.build +++ b/meson.build @@ -362,9 +362,9 @@ pkgg.generate( libraries : flashrom, version : version, - name : 'libflashrom', - filebase : 'libflashrom', - description : 'libflashrom', + name : 'flashrom', + filebase : 'flashrom', + description : 'library to interact with flashrom', )
flashrom_dep = declare_dependency(
Richard Hughes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36069 )
Change subject: Correct the pkgconfig generated file naming ......................................................................
Patch Set 1: Code-Review+1
Looks sane to me, thanks.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/36069 )
Change subject: Correct the pkgconfig generated file naming ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/36069 )
Change subject: Correct the pkgconfig generated file naming ......................................................................
Correct the pkgconfig generated file naming
The typical convention is to not use the `lib` prefix (ie `libfoo`) but instead to just use foo.
Change-Id: I5ab46418e2a1708d5c11970f1e56250f2adb7d70 Signed-off-by: Mario Limonciello mario.limonciello@dell.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/36069 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Richard Hughes richard@hughsie.com Reviewed-by: David Hendricks david.hendricks@gmail.com --- M meson.build 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Richard Hughes: Looks good to me, but someone else must approve
diff --git a/meson.build b/meson.build index bda6b08..d1f663f 100644 --- a/meson.build +++ b/meson.build @@ -362,9 +362,9 @@ pkgg.generate( libraries : flashrom, version : version, - name : 'libflashrom', - filebase : 'libflashrom', - description : 'libflashrom', + name : 'flashrom', + filebase : 'flashrom', + description : 'library to interact with flashrom', )
flashrom_dep = declare_dependency(