Change in flashrom[master]: [RFC] tests: Abstract port I/O and factor mec1308 specifics out - flashrom-gerrit

30 Apr 2021


      Attention is currently required from: Nico Huber.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52604 )
Change subject: [RFC] tests: Abstract port I/O and factor mec1308 specifics out
......................................................................
Patch Set 1:
(1 comment)
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/52604/comment/d117d6c2_bc06a158 
PS1, Line 1: #ifndef _IO_MOCK_H_
           : #define _IO_MOCK_H_
I just realised, this is a new file and it doesn't have Copyright header. Would you like to create a patch with this file and submit? I did little modifications for 51487, but I can rebase 51487 on the top and add my modifications. What do you think?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52604
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia3a424478456a7c968b3c736ba371d755c494f30
Gerrit-Change-Number: 52604
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 30 Apr 2021 09:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment