Nico Huber has posted comments on this change. ( https://review.coreboot.org/28866 )
Change subject: flashchips: Mark Spansion S25FL128P......0 as tested ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Please clarify the commit message. If it was a single chip, just drop the sentence about the ...1 entry.
https://review.coreboot.org/#/c/28866/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/28866/1//COMMIT_MSG@9 PS1, Line 9: The S25FL128P......1 gives errors while : erasing, but I have not tested further. It can only be either of them. If you select the wrong chip model, failure is expected. And the ...1 is just the wrong entry. According to the datasheet the ...1 would be marked FL128PIFL.
Or were you talking about another chip?
Also just noted, the numbers are 00 and 01 so the names in flashrom should be S25FL128P.....00 and S25FL128P.....01.