Attention is currently required from: Light. Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/62764
to look at the new patch set (#5).
Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error ......................................................................
ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error
Unsigned types show undefined behaviour if they are subtracted by a value greater than their own (mostly it wraps to the max value). Using this value for left shifting could be even more dangerous.
Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39 Signed-off-by: Aarya Chaumal aarya.chaumal@gmail.com --- M ich_descriptors.c 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/64/62764/5