Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79304?usp=email )
Change subject: flashrom_tester: Fix partial_lock_test on libflashrom ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1: I vaguely recall many discussions about this, but can't recall the details enough.
I think this fix is fine in the mean time, but obviously the write itself should fail if it is being prevented due to write protect, not the verify.
Did this regress at some point? I remember there were differences here between chromeos and upstream flashrom, have those diverged more or are in sync now?
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/37b51cb8_0151f056 : PS1, Line 299: // flashrom cli has its own default flags. `flashrom cli sets these flags by default`
File util/flashrom_tester/flashrom/src/flashromlib.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/a668b391_406d2008 : PS1, Line 200: .flag_set(FlashromFlag::FlashromFlagSkipUnreadableRegions, true); I don't see these last two being set in cli_classic.c
File util/flashrom_tester/flashrom/src/lib.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/bbe08770_28c7fdae : PS1, Line 166: /// Set default flashrom flag if necessary. `Set flags to the defaults used by the flashrom cli`
File util/flashrom_tester/src/tester.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/dc5c9380_d08fd0c8 : PS1, Line 87: info!("Setup default flashrom flag(s)"); I don't think this is a necessary log
-
Evan Benn (Code Review)