Attention is currently required from: Nico Huber, Paul Menzel, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58616 )
Change subject: Makefile: Revise C compiler check ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58616/comment/e5cbbcee_cc2ea840 PS2, Line 7: Makefile: move c compiler check to the top
Note that C (the programming language) is written in uppercase
Done
https://review.coreboot.org/c/flashrom/+/58616/comment/5520423a_6e554602 PS2, Line 9: Cleanup
Verb is spelled with a space: Clean up.
Done
https://review.coreboot.org/c/flashrom/+/58616/comment/46fb6a0d_57909d79 PS2, Line 10:
It's also changing the output, e.g. prints version, and doesn't write […]
Done
File Makefile:
https://review.coreboot.org/c/flashrom/+/58616/comment/a491194e_c93757b0 PS2, Line 896: echo $$(
Redirection through `echo` seems unnecessary.
Done
-
Thomas Heijligen (Code Review)