Attention is currently required from: Edward O'Callaghan, Martin Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75328 )
Change subject: programmer: Use correct type for flashbase
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Yes, this works. Thank you.
This one made me curious oO
Is it an academic issue or did a compiler complain? At a first glance I
couldn't spot any assignment too big for an unsigned long and neither
a conversion to a pointer.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9057e438731b9cccde0e24d5c8f758c3af1d47f
Gerrit-Change-Number: 75328
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Sat, 20 May 2023 11:37:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martin.roth@amd.corp-partner.google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment