Attention is currently required from: Sam McNally, Peter Marheine.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63902 )
Change subject: raiden_debug_spi.c: Document where raiden_debug_spi_requests are handled
......................................................................
Patch Set 2:
(2 comments)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/63902/comment/728571b0_3a8f8d89
PS2, Line 402: /* Corresponds with 'enum usb_spi_request' in platform/cr50/chip/g/usb_spi.h */
Also partially with platform/ec/chip/stm32/usb_spi.h.
Done
https://review.coreboot.org/c/flashrom/+/63902/comment/7994f7d1_b98c6f2c
PS2, Line 1451: * by adapters that only support one target
Yes, my mistake!
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/63902
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8cc78a85660190c9f750bf67994f0d59d69592d8
Gerrit-Change-Number: 63902
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 29 Apr 2022 03:59:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sam McNally
sammc@google.com
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment