Attention is currently required from: Simon Buhrow, Nico Huber, Anastasia Klimchuk.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
Patch Set 71:
(2 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/6603f713_6b71cb4b
PS70, Line 23: #include <assert.h>
This is not longer needed.
Done
https://review.coreboot.org/c/flashrom/+/66104/comment/e7cebee1_fe16a5c6
PS70, Line 1412: //if ret!=0 ??
Please remove this and other leftovers
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 71
Gerrit-Owner: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 09 Dec 2022 19:09:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Gerrit-MessageType: comment