[S] Change in flashrom[main]: erase/write: Deselect all smaller blocks when large block is selected - flashrom-gerrit

7 Oct 2024


      Attention is currently required from: Aarya, Bill XIE.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84686?usp=email )
Change subject: erase/write: Deselect all smaller blocks when large block is selected
......................................................................
Patch Set 1:
(1 comment)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/84686/comment/7b1c80a5_34ed9df3?usp... :
PS1, Line 237: /* Deselect all smaller blocks covering the same region. */
I still need to add a test for this in `tests/erase_func_algo.c`
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/84686?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Icfc18d5c090b1dcb92ab157e2c139be71af59300
Gerrit-Change-Number: 84686
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Bill XIE persmule@hardenedlinux.org
Gerrit-Attention: Bill XIE persmule@hardenedlinux.org
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Mon, 07 Oct 2024 07:45:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No