Attention is currently required from: Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69196 )
Change subject: layout: Factor out flash_region structure from romentry
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69196/comment/07b32588_217f7588
PS6, Line 16: TEST=builds
Have you done any testing with layouts that have multiple regions?
Patchset:
PS2:
That's a good question since this patch on its own doesn't have any extra context. […]
I agree commit message needs more info on why the patch exist, one more paragraph would be great, something around "The patch allows for ABC to be done / XYZ to be improved / OPQ to be fixed later in the chain".
As a reminder for Nikolai, b:260440773 is just a magic number, doesn't give any info.
Thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I768742b73db901df5b5208fcbcb8a324a06014c2
Gerrit-Change-Number: 69196
Gerrit-PatchSet: 6
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 12 Dec 2022 22:29:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment