Change in flashrom[master]: tests: Wrap strdup to help cmocka recognise memory allocation - flashrom-gerrit

16 Jul 2021


      Attention is currently required from: Nico Huber, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56323 )
Change subject: tests: Wrap strdup to help cmocka recognise memory allocation
......................................................................
Patch Set 2:
(1 comment)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/56323/comment/861a9493_1007e59a 
PS1, Line 34: char *__wrap_strdup(const char *s)
...
Maybe add a comment referencing the cmocka issue? […]
Done.
Also I decided to remove LOG_ME from __wrap_strdup. As a person who is looking at test logs very often, I realised it just adds noise to the logs. This wrap is special, not like the others.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/56323
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I56aef6b342752d80995c36ab075b12198fc101d9
Gerrit-Change-Number: 56323
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 16 Jul 2021 00:20:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment