Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/71972 )
Change subject: flashrom_tester: Rename lock_test hwwp_locks_swwp_test ......................................................................
flashrom_tester: Rename lock_test hwwp_locks_swwp_test
Rename lock_test to hwwp_locks_swwp_test.
BUG=b:235916336 BRANCH=None TEST=None
Change-Id: I6080622755ff16d8fba7044b38f9e09db0c62f97 Signed-off-by: Evan Benn evanbenn@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/71972 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Peter Marheine pmarheine@chromium.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M util/flashrom_tester/src/tests.rs 1 file changed, 22 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Peter Marheine: Looks good to me, but someone else must approve
diff --git a/util/flashrom_tester/src/tests.rs b/util/flashrom_tester/src/tests.rs index 8369a94..13ba050 100644 --- a/util/flashrom_tester/src/tests.rs +++ b/util/flashrom_tester/src/tests.rs @@ -100,7 +100,7 @@ &("WP_Region_List", wp_region_list_test), &("Erase_and_Write", erase_write_test), &("Fail_to_verify", verify_fail_test), - &("Lock", lock_test), + &("HWWP_Locks_SWWP", hwwp_locks_swwp_test), &("Lock_top_quad", partial_lock_test(LayoutNames::TopQuad)), &( "Lock_bottom_quad", @@ -196,7 +196,7 @@ }
/// Verify that enabling hardware write protect prevents disabling software write protect. -fn lock_test(env: &mut TestEnv) -> TestResult { +fn hwwp_locks_swwp_test(env: &mut TestEnv) -> TestResult { if !env.wp.can_control_hw_wp() { return Err("Lock test requires ability to control hardware write protect".into()); }