Attention is currently required from: Felix Singer, Thomas Heijligen, roman.stingler@gmail.com. Vasily Galkin has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179 )
Change subject: flashchips.c: Add support for IS25WQ040 ......................................................................
Patch Set 2:
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58179/comment/ff8f6944_47d6c8be PS1, Line 7: Add support for IS25WQ040
Add `flashchips. […]
Done
https://review.coreboot.org/c/flashrom/+/58179/comment/bf40a07f_ead651cb PS1, Line 10: Signed-off-by: Roman Stingler roman.stingler@gmail.com
Put the Sign-offs after the line with the Change-Id. This one should come first.
Done
https://review.coreboot.org/c/flashrom/+/58179/comment/7d487b87_c77445ff PS1, Line 11:
Add a link to the datasheet.
Done
https://review.coreboot.org/c/flashrom/+/58179/comment/9079f446_ac912d11 PS1, Line 12:
Did you test it? How? Which programmer did you use?
Done
Patchset:
PS2: resolved issues in commit message. (it's my first usage of Gerrit, so tell me if something is wrong in review handling from my side)