[M] Change in flashrom[master]: cli_classic.c: Factor out rom bus limits exceeded validation
Attention is currently required from: Felix Singer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68661 )
Change subject: cli_classic.c: Factor out rom bus limits exceeded validation ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68661/comment/d2eed255_c4b20004 PS3, Line 9: Cave
nit: `Carve` with an `r`?
Done
https://review.coreboot.org/c/flashrom/+/68661/comment/0e184d84_5db857ff PS3, Line 11: pairingings
nit: There's an extra `ing` in `pairings`
Done
https://review.coreboot.org/c/flashrom/+/68661/comment/41f23286_1e8a279d PS3, Line 11: it's
nit: possessive `its`
Done
Patchset:
PS4:
Looks good to me but some issues are open
Done.
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/68661/comment/926a3e11_efda8b66 PS3, Line 565: exceed
nit: exceed*ed*
Done
https://review.coreboot.org/c/flashrom/+/68661/comment/fa5896e7_c4a30af3 PS3, Line 565: relevent
nit: relev*a*nt
Done
https://review.coreboot.org/c/flashrom/+/68661/comment/be7743db_682f6991 PS3, Line 575: (bitcount(commonbuses) > limitexceeded)
nit: drop extra set of parentheses
Done
-
Edward O'Callaghan (Code Review)