Attention is currently required from: Nico Huber, Thomas Heijligen. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61300 )
Change subject: Makeile: reenable internal programmer for mipsel ......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/61300/comment/840926d1_0da99e44 PS3, Line 332: # Disable the internal programmer on unsupported architectures (everything but x86 and mipsel)
(mark_unsupported) works fine, it's just hard to understand what it does.
I see; it doesn't do what I thought it did, but makes some amount of sense.
it only happened to work ... when using Meson
I don't understand why it worked, but I believe builds were using internal on ARM even before Meson support existed. I see from history that Meson support wasn't added until years after the change to mark other architectures as unsupported for internal, so it was still being built somehow.
We can change that behavior of course, as I depicted earlier. I think we should just do that.
I agree, assumming I've understood you correctly. There are now users depending on the MTD delegation in internal, so it should be made to build on all (Linux with MTD support) systems.
-
Peter Marheine (Code Review)