Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52945 )
Change subject: programmer_table: convert entries to pointers
......................................................................
Patch Set 6:
(3 comments)
File print_wiki.c:
https://review.coreboot.org/c/flashrom/+/52945/comment/0a1d9e2d_846e4f0f
PS3, Line 403: *prog
This is what I meant with "and below", apparently.
ok, done
https://review.coreboot.org/c/flashrom/+/52945/comment/4bfd8a3a_2e95bba1
PS3, Line 415: *prog
and this
Found this also
https://review.coreboot.org/c/flashrom/+/52945/comment/48a15d55_eeceab17
PS3, Line 429: *prog
and this […]
I think for now we should stay with the indexed based iteration. This might be the more common one.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52945
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifbb0ee4db5a85b1cd2afeafe4dca838579f79878
Gerrit-Change-Number: 52945
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Xiang W
wxjstz@126.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Tue, 08 Jun 2021 16:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment