Attention is currently required from: Hung-Te Lin, Nico Huber, Subrata Banik, Edward O'Callaghan, Daniel Campello.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62213 )
Change subject: flashrom.c: Implement file-based locking semantics
......................................................................
Patch Set 25:
(1 comment)
Patchset:
PS25:
A few things that feel not good about this implementation:
- (lib)flashrom supports systems with a limited filesystem implementation. (libpayload)
- unistd.h may not be available on some platforms (DJGPP/DOS)
- The filelock paths are not run Windows compatible
- It prevent the usage of multiple different programmer at the same time (e.g. usb / ftdi)
IMO we have to look closer when the use of a lock is wise and not try to lock in any case.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62213
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I19cb4e3bf14caeb67c3e8100a20395b264c5113a
Gerrit-Change-Number: 62213
Gerrit-PatchSet: 25
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Comment-Date: Thu, 19 May 2022 16:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment