Nico Huber has posted comments on this change. ( https://review.coreboot.org/23022 )
Change subject: make args for -r/-w/-v non-positional and optional
......................................................................
Patch Set 6: Code-Review-2
I'm missing a check for spurious arguments. I have no idea how to
implement it (straightforward) together with the non-positional file
names. Currently, if you have a typo in your command line (e.g. forget
a dash before an option), things may just be ignored...
So why make it non-positional?
--
To view, visit
https://review.coreboot.org/23022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 23022
Gerrit-PatchSet: 6
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Louis Yung-Chieh Lo
yjlou@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 10 Jan 2018 12:48:04 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes