Attention is currently required from: Aarya, Anastasia Klimchuk, Hsuan-ting Chen, Nikolai Artemiev.
Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82496?usp=email )
Change subject: Correct get_flash_region() to use inclusive upper bounds
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS6:
I am wondering, this path in ichspi (ich_get_region) is the same in Chrome OS, is it possible to do […]
I tested reading flash on a yaviks board both with and without this patch, and it looks okay. In both cases the debug messages correctly indicated the extent of the IFD regions that were being read.
Added a TEST line to the commit message to reflect this.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82496?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia0ca867aef33b598c2697fc264807fa5e29683ec
Gerrit-Change-Number: 82496
Gerrit-PatchSet: 7
Gerrit-Owner: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 28 May 2024 05:27:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org