[S] Change in flashrom[master]: rayer_spi.c: Drop lpt_outbyte intermediate var - flashrom-gerrit

9 Oct 2022


      Attention is currently required from: Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68232 )
Change subject: rayer_spi.c: Drop lpt_outbyte intermediate var
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File rayer_spi.c:
https://review.coreboot.org/c/flashrom/+/68232/comment/9804df69_ac3ef10b 
PS1, Line 321: 	/* Get the initial value before writing to any line. */
...
I didn't yet touch it as I didn't change the meaning of the code here. […]
Probably. I'm fine with keeping it for now since the intention of this commit is just cleaning up some code here, and also the comment existed before. Marking as resolved.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/68232
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Idedabb7b1c401d666b3b7e621e75704c7e765fd1
Gerrit-Change-Number: 68232
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Sun, 09 Oct 2022 01:56:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment