Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83899?usp=email )
Change subject: flashchips: adding GD25LB512MF/GD25LR512MF ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/83899/comment/2f128ef6_05d063cb?usp... : PS1, Line 14: The datasheet is under controll. : You can either refer to GD25LB512MF datasheet. : Or I send you a copy.
If you say the both datasheets is identical, that's fine, no need to send me the second one. […]
Done
https://review.coreboot.org/c/flashrom/+/83899/comment/6820e7f3_e6ffcf7b?usp... : PS1, Line 18: Tested
Have you tested both models? Maybe you can add here "tested both models".
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83899/comment/0d7c42a0_c2905e47?usp... : PS1, Line 7109: BP3
SPI_PRETTYPRINT_STATUS_REGISTER_BP4_SRWD here? (instead of BP3)
Done
https://review.coreboot.org/c/flashrom/+/83899/comment/77acec98_6468ec90?usp... : PS1, Line 7118: tb = {STATUS1, 6, RW},
I think you need to add a usual comment here […]
Done