Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Eric Park has posted comments on this change by Eric Park. ( https://review.coreboot.org/c/flashrom/+/86990?usp=email )
Change subject: flashchips: Add XMC XM25QH64A ......................................................................
Patch Set 6: Code-Review+1
(6 comments)
Patchset:
PS1: Sorry this took so long. I was initially trying to test on my Windows machine, but for some reason flashrom+MSYS2-MINGW64+my CH341A programmer weren't playing nicely together and would give me some programmer initialization error. I moved over to a NixOS system and rebuilt flashrom and it worked perfectly there on the first try.
I have a corpus of a Chinese CCTV camera with that chip so I tried reading off of it twice, and both binary files share the same MD5sum. Running strings show snippets from the Chinese firmware with "Tuya"-related strings on it so the data I'm getting back seems to be sound. Flashrom did warn me that "WP" was untested on this flash chip, which I'm guessing is the writing/erase portion. Flashrom also correctly identified the chip model.
Patchset:
PS4:
Eric, thank you for the patch! I added a few comments. […]
Thank you for the comments! I've modified the commit with the changes. Please see comment above regarding testing.
Commit Message:
https://review.coreboot.org/c/flashrom/+/86990/comment/0777d42e_2eeb5e5d?usp... : PS4, Line 7: XMC25QH64A
Let's be exact so that it's searchable, call it `XMC XM25QH64A`
Done
https://review.coreboot.org/c/flashrom/+/86990/comment/ec8dfb59_2d1e1a81?usp... : PS4, Line 18: Signed-off-by: Eric Park me@ericswpark.com
Add yourself too as Co-authored-by (keep the sign off line too)
Done
File flashchips/xmc.c:
https://review.coreboot.org/c/flashrom/+/86990/comment/41536c11_896e15f5?usp... : PS4, Line 251: .name = "XM25QH64A",
I would put this entry just before XM25QH128A in this file too (same as their ids are ordered), woul […]
Done
File include/flashchips.h:
https://review.coreboot.org/c/flashrom/+/86990/comment/3579fc5d_f8396bcb?usp... : PS4, Line 1085: #define XMC_ID 0x20 /* same as ST_ID */ : #define XMC_XM25QH256B 0x6019 : #define XMC_XM25QH128B 0x6018 : #define XMC_XM25QH64A 0x7017 : #define XMC_XM25QH64B 0x6017 : #define XMC_XM25QH32B 0x4016 /* 0x6016 for QPI mode */ : #define XMC_XM25QH16B 0x4015 : #define XMC_XM25QH80B 0x4014 : #define XMC_XM25QH40B 0x4013 : #define XMC_XM25QU256B 0x7019 : #define XMC_XM25QU128B 0x5018 : #define XMC_XM25QU64A 0x3817 : #define XMC_XM25QU64B 0x5017 : #define XMC_XM25QU40B 0x5013 : #define XMC_XM25QU20B 0x5012
I know it was like this in the original pull request, but we don't need to do the aliasing. […]
Done
-
Eric Park (Code Review)