David Hendricks has posted comments on this change. ( https://review.coreboot.org/23701 )
Change subject: flashchips: Add Zettadevice ZD25D40 ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/23701/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/23701/2//COMMIT_MSG@14 PS2, Line 14: Signed-off-by: David Hendricks david.hendricks@gmail.com
Remove the blank line, and move the Change-Id even above the Signed-off-by line.
Done
https://review.coreboot.org/#/c/23701/2/flashchips.h File flashchips.h:
https://review.coreboot.org/#/c/23701/2/flashchips.h@960 PS2, Line 960: #define ZETTADEVICE_ID 0xBA /* Zetta Device */
0xba says the datasheet (0x9f is the rdid instruction?)
Yep, silly error on my part. Should be fixed now.