Nico Huber has posted comments on this change. ( https://review.coreboot.org/25706 )
Change subject: linux_mtd: Import driver from ChromiumOS
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/25706/10/linux_mtd.c
File linux_mtd.c:
https://review.coreboot.org/#/c/25706/10/linux_mtd.c@56
PS10, Line 56: msg_perr("Cannot open %s\n", path);
Hmmp, this is on the default path for `-p internal` now...
Easy workaround: Make it msg_pdbg(). Better: Check in advance
if the file exists in try_mtd() case.
--
To view, visit
https://review.coreboot.org/25706
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d6bb282863a5cf69909e28a1fc752b35f1b9599
Gerrit-Change-Number: 25706
Gerrit-PatchSet: 10
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Brian Norris
briannorris@chromium.org
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 May 2018 12:10:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No