Attention is currently required from: Wonkyu Kim, Subrata Banik, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 )
Change subject: ichspi: Add support for Meteor Lake
......................................................................
Patch Set 1:
(2 comments)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/b74c4724_948141e3
PS1, Line 118: ",
missing from here too.
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/77bd6af7_80615a4f
PS1, Line 130: "\t- "gemini" for Intel's Gemini Lake SoC.\n"
missing line here
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0a2ffe2ba8d96c90d89b77e0d8583d179ff02a75
Gerrit-Change-Number: 62783
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 14 Mar 2022 10:24:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment