Change in flashrom[master]: flashchips: Add W25Q256JW_IM

List overview All Threads
Download

newer

older

Change in flashrom[master]:...

David Hendricks (Code Review)

15 Jun 2020 15 Jun '20

5:46 a.m.

David Hendricks has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_IM ......................................................................

flashchips: Add W25Q256JW_IM

W25Q256JW has two variants, the W25Q256JW with device ID 0x6019 added in CB:40855 and the W25q256JW-IM which is added by this patch.

Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/42386/1

diff --git a/flashchips.c b/flashchips.c index b4006df..dc43162 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16808,6 +16808,53 @@

{ .vendor = "Winbond", + .name = "W25Q256JW", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q256_JW, + .total_size = 32768, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_21, + }, { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_dc, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1700, 1950}, + }, + + { + .vendor = "Winbond", .name = "W25Q32.V", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, diff --git a/flashchips.h b/flashchips.h index e5ef390..2a0cf80 100644 --- a/flashchips.h +++ b/flashchips.h @@ -945,6 +945,7 @@ #define WINBOND_NEX_W25Q256JV_M 0x7019 /* W25Q256JV_M (QE=0) */ #define WINBOND_NEX_W25Q64JW 0x8017 #define WINBOND_NEX_W25Q128_DTR 0x8018 /* W25Q128JW_DTR */ +#define WINBOND_NEX_W25Q256_JW 0x8019 /* W25Q256JW */

#define WINBOND_ID 0xDA /* Winbond */ #define WINBOND_W19B160BB 0x49

Attachments:

attachment.htm (text/html — 6.7 KB)

Show replies by date

David Hendricks (Code Review)

15 Jun 15 Jun

5:55 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256.W_IM

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/42386

to look at the new patch set (#2).

Change subject: flashchips: Add W25Q256.W_IM ......................................................................

flashchips: Add W25Q256.W_IM

W25Q256JW has two variants, the W25Q256JW with device ID 0x6019 added in CB:40855 and the W25Q256JW-IM with device ID 0x8019 added by this patch.

Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/42386/2

David Hendricks (Code Review)

5:55 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256.W_IM

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256.W_IM ......................................................................

Patch Set 2:

The W25Q256JW patch is at CB:40855

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 15 Jun 2020 05:55:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Simon Buhrow (Code Review)

7:20 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256.W_IM

Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256.W_IM ......................................................................

Patch Set 2:

(1 comment)

...

Patch Set 2:

The W25Q256JW patch is at CB:40855

https://review.coreboot.org/c/flashrom/+/42386/2/flashchips.h File flashchips.h:

https://review.coreboot.org/c/flashrom/+/42386/2/flashchips.h@948 PS2, Line 948: WINBOND_NEX_W25Q256_JW Thanks for your last comment. I wasn´t aware of this. May be you can add '-IM' (or 'DTR', which seems to give the same information, s. https://www.winbond.com/resource-files/W25Q256JW SPI RevG 11252019 Plus.pdf ) here to the string to better mark the difference?

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 2 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Simon Buhrow Gerrit-Comment-Date: Mon, 15 Jun 2020 07:20:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

David Hendricks (Code Review)

10:49 p.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/42386

to look at the new patch set (#3).

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

flashchips: Add W25Q256JW_DTR

W25Q256JW currently has two variants, the W25Q256JW with device ID 0x6019 added in CB:40855 and the W25Q256JW_DTR (aka W25Q256JW-IM) with device ID 0x8019 added by this patch.

Winbind W25Q256-series chips have a few device IDs: 0x4019: W25Q256FV 0x6019: W25Q256JW 0x7019: W25Q256JV 0x8019: W25Q256JW_DTR

Hence we need to be more specific with naming than usual to avoid a false positive with wildcards.

Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/42386/3

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Simon Buhrow Gerrit-MessageType: newpatchset

Simon Buhrow (Code Review)

16 Jun 16 Jun

7:27 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 16 Jun 2020 07:27:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

8:34 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 3: Code-Review+1

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow simon.buhrow@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 16 Jun 2020 08:34:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

4 Aug 4 Aug

10:27 p.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 04 Aug 2020 22:27:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

10:28 p.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 3:

(1 comment)

This also needs a rebase 😞

https://review.coreboot.org/c/flashrom/+/42386/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/42386/3//COMMIT_MSG@13 PS3, Line 13: Winbind Winb*o*nd

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 3 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 04 Aug 2020 22:28:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

David Hendricks (Code Review)

17 Aug 17 Aug

12:15 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Hello Simon Buhrow, build bot (Jenkins), Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/42386

to look at the new patch set (#4).

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

flashchips: Add W25Q256JW_DTR

W25Q256JW currently has two variants, the W25Q256JW with device ID 0x6019 added in CB:40855 and the W25Q256JW_DTR (aka W25Q256JW-IM) with device ID 0x8019 added by this patch.

Winbind W25Q256-series chips have a few device IDs: 0x4019: W25Q256FV 0x6019: W25Q256JW 0x7019: W25Q256JV 0x8019: W25Q256JW_DTR

Hence we need to be more specific with naming than usual to avoid a false positive with wildcards.

Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/42386/4

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 4 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

David Hendricks (Code Review)

12:17 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Hello build bot (Jenkins), Simon Buhrow, Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/42386

to look at the new patch set (#5).

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

flashchips: Add W25Q256JW_DTR

W25Q256JW currently has two variants, the W25Q256JW with device ID 0x6019 added in CB:40855 and the W25Q256JW_DTR (aka W25Q256JW-IM) with device ID 0x8019 added by this patch.

Winbond W25Q256-series chips have a few device IDs: 0x4019: W25Q256FV 0x6019: W25Q256JW 0x7019: W25Q256JV 0x8019: W25Q256JW_DTR

Hence we need to be more specific with naming than usual to avoid a false positive with wildcards.

Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/42386/5

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

David Hendricks (Code Review)

12:18 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/flashrom/+/42386/2/flashchips.h File flashchips.h:

https://review.coreboot.org/c/flashrom/+/42386/2/flashchips.h@948 PS2, Line 948: WINBOND_NEX_W25Q256_JW

...

Thanks for your last comment. […]

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 17 Aug 2020 00:18:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Simon Buhrow Gerrit-MessageType: comment

Simon Buhrow (Code Review)

18 Aug 18 Aug

11:17 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 5: Code-Review+1

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 18 Aug 2020 11:17:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

2:01 p.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 5: Code-Review+2

(1 comment)

https://review.coreboot.org/c/flashrom/+/42386/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/42386/5//COMMIT_MSG@10 PS5, Line 10: CB:40855 commit be4682d

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 5 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 18 Aug 2020 14:01:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

David Hendricks (Code Review)

19 Aug 19 Aug

5:11 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

Hello Simon Buhrow, build bot (Jenkins), Paul Menzel, Angel Pons,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/42386

to look at the new patch set (#6).

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

flashchips: Add W25Q256JW_DTR

W25Q256JW currently has two variants, the W25Q256JW with device ID 0x6019 added in commit be4682d and the W25Q256JW_DTR (aka W25Q256JW-IM) with device ID 0x8019 added by this patch.

Winbond W25Q256-series chips have a few device IDs: 0x4019: W25Q256FV 0x6019: W25Q256JW 0x7019: W25Q256JV 0x8019: W25Q256JW_DTR

Hence we need to be more specific with naming than usual to avoid a false positive with wildcards.

Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Signed-off-by: David Hendricks david.hendricks@gmail.com --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/86/42386/6

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

David Hendricks (Code Review)

5:11 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/flashrom/+/42386/5//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/42386/5//COMMIT_MSG@10 PS5, Line 10: CB:40855

...

commit be4682d

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 19 Aug 2020 05:11:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

David Hendricks (Code Review)

5:12 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/flashrom/+/42386/3//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/flashrom/+/42386/3//COMMIT_MSG@13 PS3, Line 13: Winbind

...

Winb*o*nd

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 6 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 19 Aug 2020 05:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

David Hendricks (Code Review)

5:12 a.m.

New subject: Change in flashrom[master]: flashchips: Add W25Q256JW_DTR

David Hendricks has submitted this change. ( https://review.coreboot.org/c/flashrom/+/42386 )

Change subject: flashchips: Add W25Q256JW_DTR ......................................................................

flashchips: Add W25Q256JW_DTR

W25Q256JW currently has two variants, the W25Q256JW with device ID 0x6019 added in commit be4682d and the W25Q256JW_DTR (aka W25Q256JW-IM) with device ID 0x8019 added by this patch.

Winbond W25Q256-series chips have a few device IDs: 0x4019: W25Q256FV 0x6019: W25Q256JW 0x7019: W25Q256JV 0x8019: W25Q256JW_DTR

Hence we need to be more specific with naming than usual to avoid a false positive with wildcards.

Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Signed-off-by: David Hendricks david.hendricks@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/42386 Reviewed-by: Simon Buhrow Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M flashchips.c M flashchips.h 2 files changed, 48 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Simon Buhrow: Looks good to me, but someone else must approve

diff --git a/flashchips.c b/flashchips.c index 09ac9b4..8b5b5cc 100644 --- a/flashchips.c +++ b/flashchips.c @@ -16887,6 +16887,53 @@

{ .vendor = "Winbond", + .name = "W25Q256JW_DTR", + .bustype = BUS_SPI, + .manufacture_id = WINBOND_NEX_ID, + .model_id = WINBOND_NEX_W25Q256_DTR, + .total_size = 32768, + .page_size = 256, + /* supports SFDP */ + /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44, read ID 0x4B */ + /* FOUR_BYTE_ADDR: supports 4-bytes addressing mode */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_21, + }, { + .eraseblocks = { {4 * 1024, 8192} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {32 * 1024, 1024} }, + .block_erase = spi_block_erase_52, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_dc, + }, { + .eraseblocks = { {64 * 1024, 512} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {32 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .printlock = spi_prettyprint_status_register_plain, /* TODO: improve */ + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {1700, 1950}, + }, + + { + .vendor = "Winbond", .name = "W25Q32.V", .bustype = BUS_SPI, .manufacture_id = WINBOND_NEX_ID, diff --git a/flashchips.h b/flashchips.h index 4ae6c07..5b7937f 100644 --- a/flashchips.h +++ b/flashchips.h @@ -948,6 +948,7 @@ #define WINBOND_NEX_W25Q256JV_M 0x7019 /* W25Q256JV_M (QE=0) */ #define WINBOND_NEX_W25Q64JW 0x8017 #define WINBOND_NEX_W25Q128_DTR 0x8018 /* W25Q128JW_DTR */ +#define WINBOND_NEX_W25Q256_DTR 0x8019 /* W25Q256JW_DTR aka W25Q256256JW-IM */

#define WINBOND_ID 0xDA /* Winbond */ #define WINBOND_W19B160BB 0x49

-- To view, visit https://review.coreboot.org/c/flashrom/+/42386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I50a6de2c915f9201c458378fcc49130ead73d8c4 Gerrit-Change-Number: 42386 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1594

days inactive

1659

days old

flashrom-gerrit@flashrom.org

17 comments

4 participants

tags (0)

participants (4)

Angel Pons (Code Review)
David Hendricks (Code Review)
Paul Menzel (Code Review)
Simon Buhrow (Code Review)