Elyes HAOUAS has posted comments on this change. ( https://review.coreboot.org/25683 )
Change subject: Add support for National Instruments USB-845x devices
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/25683/3/flashrom.c
File flashrom.c:
https://review.coreboot.org/#/c/25683/3/flashrom.c@417
PS3, Line 417: {
: .name = "ni845x_spi",
: .type = OTHER, // choose other because NI-845x uses own USB implementation
: .devs.note = "National Instruments USB-845x\n",
: .init = ni845x_spi_init,
: .map_flash_region = fallback_map,
: .unmap_flash_region = fallback_unmap,
: .delay = internal_delay,
: },
Please use tabs for indentation
--
To view, visit
https://review.coreboot.org/25683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9477b6f0193bfdf20bbe63421a7fb97b597ec549
Gerrit-Change-Number: 25683
Gerrit-PatchSet: 3
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Elyes HAOUAS
ehaouas@noos.fr
Gerrit-CC: Márton Miklós
martonmiklosqdev@gmail.com
Gerrit-Comment-Date: Sun, 24 Jun 2018 13:34:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No