Attention is currently required from: Anastasia Klimchuk, DZ, Nikolai Artemiev, Stefan Reinauer, Subrata Banik.
Bora Guvendik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/flashrom/+/82626?usp=email )
Change subject: flashchips: add support for MX77U51250F chip
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/82626/comment/79ae0811_edde710f?usp... :
PS3, Line 10:
Please add test information in commit message. […]
Done
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82626/comment/51b4a3ce_cb06266b?usp... :
PS3, Line 11618: 65536
we might need to fake this part to show the max capacity is 32MB […]
Leaving it 64MB as per Anastasia's input
https://review.coreboot.org/c/flashrom/+/82626/comment/497659d8_64a18bdf?usp... :
PS3, Line 11620: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA,
Thank you for explanation! I see, no need for any of FEATURE_WRSR2 or FEATURE_WRSR3 etc. […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/82626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I2c2e94f01dc63f60cf636bc6afe1f033e2a6f83c
Gerrit-Change-Number: 82626
Gerrit-PatchSet: 4
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 12 Aug 2024 21:01:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DZ
danielzhang@mxic.com.cn
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org