Change in flashrom[master]: spi_master: Introduce SPI_MASTER_4BA feature flag - flashrom-gerrit

25 Dec 2017


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/22421 )
Change subject: spi_master: Introduce SPI_MASTER_4BA feature flag
......................................................................
Patch Set 6:
...
I think I get what you were saying earlier... I don't know if it's
worth blocking this patch, though. If you have time to implement
the better approach by all means do so and I'll be happy to review
it. I can take a swing at it too, but I probably won't get around
to it for another month.
Well, it's not that this path introduces any problem that doesn't
already exist. It's just more visible what can go wrong, IMO. Let's
just merge it (maybe after you gave it a final test round).
-- 
To view, visit https://review.coreboot.org/22421
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife66e3fc49b9716f9c99cad957095b528135ec2c
Gerrit-Change-Number: 22421
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 Dec 2017 12:09:19 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No