Attention is currently required from: Cattus QQ.
Anastasia Klimchuk has posted comments on this change by Cattus QQ. ( https://review.coreboot.org/c/flashrom/+/85527?usp=email )
Change subject: Add Glasgow to supported serprog programmers documentation ......................................................................
Patch Set 2: Code-Review+2
(6 comments)
Patchset:
PS1:
I'm not sure why this is happening. I followed step 6, in my 'https://review.coreboot. […]
As of right now: your last patch update produced an email from "Cattus QQ", so you made it work, all good! :)
PS1:
Thanks for being so nice Anastasia!
You are very welcome!
Commit Message:
https://review.coreboot.org/c/flashrom/+/85527/comment/3ca4ff16_ca02b66f?usp... : PS1, Line 10: the project wouldnt compile with meson for me (MacOS 15.1)
I will try again with these updates.
So just to confirm: does flashrom compile for you? is it only documentation that does not?
https://review.coreboot.org/c/flashrom/+/85527/comment/243a67ac_8d1bae8f?usp... : PS1, Line 9: Updated the serprog overview page with info about the Glasgow Interface Explorer as a valid programmer. : Wasnt able to test as the project wouldnt compile with meson for me (MacOS 15.1) : but tried to make it as similar as possible to what was already there.
Apologies, will fix, thankyou!
Done
File doc/supported_hw/supported_prog/serprog/overview.rst:
https://review.coreboot.org/c/flashrom/+/85527/comment/7eb9e0ff_71717b98?usp... : PS1, Line 105: Source for the Glasgow Project can be found `here https://github.com/GlasgowEmbedded/glasgow`_
This is my first time using rst and gerrit, sorry for all the newbie mistakes! […]
The latest version does not produce any warnings, all good.
I don't remember which "here" produced a warning, first or the second, but it doesn't really matter: as long as you know that the goal is not to have repeated link text.
https://review.coreboot.org/c/flashrom/+/85527/comment/55e1a854_566ba879?usp... : PS1, Line 108: 76hPuPkpDOTAxj7TegVqV8UkmKEjZ8TvLLBoDoVPpw
Yep that definitely shouldn't be there. Thanks.
Done