Scott Chao has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40275 )
Change subject: flashchips: support for Winbond W25Q64JW
......................................................................
Patch Set 8:
Patch Set 5: Code-Review+1
(1 comment)
Looks good, thank you! One small nit in the commit message, though.
Note that flashrom loses the "Verified" score when editing the commit message. To make Jenkins run again, you can trigger a rebase (there's a button on Gerrit, around the top right corner).
When I triggered a rebase, it showed "Could not perform action: Change is already up to date.". Is that correct?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40275
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8637129421a3b0f96bd8dffa4f50783ea6931967
Gerrit-Change-Number: 40275
Gerrit-PatchSet: 8
Gerrit-Owner: Scott Chao
scott.chao@bitland.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper.chang@bitland.corp-partner.google.com
Gerrit-CC: Paul Ma
magf@bitland.com.cn
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Apr 2020 13:51:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment