Attention is currently required from: Hsuan Ting Chen.
Hello Hsuan Ting Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/82231?usp=email
to review the following change.
Change subject: flashrom-tester: Add workspace to Cargo.toml ......................................................................
flashrom-tester: Add workspace to Cargo.toml
There are 5 unit tests under flashrom/src/cmd.rs. However, ChromeOS uses the ebuild wrapper: ecargo_test to build and run rust unit tests, which will only run the tests under src/* but not flashrom/src/* and will skip all the tests in cmd.rs.
Add flashrom/ into [workspace] to ensure we could always run them in building flashrom-tester for ChromeOS.
References: * ebuild of flashrom-tester: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/r... * ecarg_test: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/r...
BUG=b:338962302 TEST=FEATURES=test emerge-corsola flashrom-tester Could see tests like cmd::tests::decode_io_opt ... ok
Change-Id: Ic23bc35592e6d7d8dd24c71630ea9a2eb2d58573 Signed-off-by: Hsuan Ting Chen roccochen@chromium.org --- M util/flashrom_tester/Cargo.toml 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/82231/1
diff --git a/util/flashrom_tester/Cargo.toml b/util/flashrom_tester/Cargo.toml index a76a5b4..50c73dd 100644 --- a/util/flashrom_tester/Cargo.toml +++ b/util/flashrom_tester/Cargo.toml @@ -15,6 +15,9 @@ name = "flashrom_tester" required-features = ["cli"]
+[workspace] +members = [".", "flashrom"] + [dependencies] atty = "0.2" built = { version = "0.5", features = ["chrono"] }