Attention is currently required from: Nico Huber, Michał Żygowski, Michał Kopeć. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64253 )
Change subject: ichspi: Add Intel Alder Lake-S support ......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File chipset_enable.c:
https://review.coreboot.org/c/flashrom/+/64253/comment/6c2dfb50_b1f4d27f PS1, Line 2177: 0x7a8a, B_S, NT, "Intel", "W685
The device IDs were taken from Intel doc #619362 (Intel 600, 700 Series PCH EDS Vol1), which is not […]
Ack, thanks for providing me the reference
https://review.coreboot.org/c/flashrom/+/64253/comment/75b37f27_a6ea0b6d PS1, Line 2180: {0x8086, 0x7a0d, B_S, NT, "Intel", "WM790", enable_flash_pch600}, : {0x8086, 0x7a0c, B_S, NT, "Intel", "HM770", enable_flash_pch600},
Removed these 2 chipsets, since they don't exist yet. […]
Good plan
-
Thomas Heijligen (Code Review)