Shawn Anastasio has posted comments on this change. ( https://review.coreboot.org/23057 )
Change subject: buspirate_spi: Add support for variable serial speeds
......................................................................
Patch Set 3:
My reasoning is that the Bus Pirate itself offers options for different baud rates, including many of the values included in the table. I just thought it best to expose as much of the Bus Pirate's feature set as possible and let the user choose between them. The extra values in my table are intermediate values that the Bus Pirate's menu doesn't offer by default but are still slower than the max of 2M. Also, the table omits values too slow to be usable (<9600 baud) for this purpose.
--
To view, visit
https://review.coreboot.org/23057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3706f17a94fdf056063f2ad4a5f0a219665cdcbf
Gerrit-Change-Number: 23057
Gerrit-PatchSet: 3
Gerrit-Owner: Shawn Anastasio
shawnanastasio@yahoo.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Shawn Anastasio
shawnanastasio@yahoo.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 04 Jan 2018 23:27:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No