Attention is currently required from: Bill XIE.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84567?usp=email )
Change subject: ichspi: Change the opcode position for reprogramming on the fly 2->4
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Oh you put my patch first in the chain, this is so nice thank you! :)
I think CB:84253 would fix the issue by itself, but I still think this patch is useful, it reduces the number of "reprogramming operations".
I also wanted to ask, maybe you can test the chain? Or maybe you did it already. Thank you!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/84567?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I6bc855daedf0af2e8de191f23a3512de3ebc3fef
Gerrit-Change-Number: 84567
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Comment-Date: Sat, 05 Oct 2024 08:47:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No