Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35826 )
Change subject: chipset_enable.c: Mark Intel Q75 as DEP ......................................................................
chipset_enable.c: Mark Intel Q75 as DEP
Tested reading, writing and erasing the internal flash chip using an HP Pro 6300 SFF mainboard with an Intel Q75 PCH. However, since ME-enabled chipsets are marked as DEP instead of OK, this one shall also be.
Change-Id: I273af0eb33e74b31bc4fdc95362527bba080c5a0 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/26/35826/1
diff --git a/chipset_enable.c b/chipset_enable.c index f02ba87..b55852c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1823,7 +1823,7 @@ {0x8086, 0x1e44, B_FS, DEP, "Intel", "Z77", enable_flash_pch7}, {0x8086, 0x1e46, B_FS, NT, "Intel", "Z75", enable_flash_pch7}, {0x8086, 0x1e47, B_FS, NT, "Intel", "Q77", enable_flash_pch7}, - {0x8086, 0x1e48, B_FS, NT, "Intel", "Q75", enable_flash_pch7}, + {0x8086, 0x1e48, B_FS, DEP, "Intel", "Q75", enable_flash_pch7}, {0x8086, 0x1e49, B_FS, DEP, "Intel", "B75", enable_flash_pch7}, {0x8086, 0x1e4a, B_FS, DEP, "Intel", "H77", enable_flash_pch7}, {0x8086, 0x1e53, B_FS, NT, "Intel", "C216", enable_flash_pch7},
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35826 )
Change subject: chipset_enable.c: Mark Intel Q75 as DEP ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35826 )
Change subject: chipset_enable.c: Mark Intel Q75 as DEP ......................................................................
chipset_enable.c: Mark Intel Q75 as DEP
Tested reading, writing and erasing the internal flash chip using an HP Pro 6300 SFF mainboard with an Intel Q75 PCH. However, since ME-enabled chipsets are marked as DEP instead of OK, this one shall also be.
Change-Id: I273af0eb33e74b31bc4fdc95362527bba080c5a0 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/35826 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M chipset_enable.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/chipset_enable.c b/chipset_enable.c index f02ba87..b55852c 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -1823,7 +1823,7 @@ {0x8086, 0x1e44, B_FS, DEP, "Intel", "Z77", enable_flash_pch7}, {0x8086, 0x1e46, B_FS, NT, "Intel", "Z75", enable_flash_pch7}, {0x8086, 0x1e47, B_FS, NT, "Intel", "Q77", enable_flash_pch7}, - {0x8086, 0x1e48, B_FS, NT, "Intel", "Q75", enable_flash_pch7}, + {0x8086, 0x1e48, B_FS, DEP, "Intel", "Q75", enable_flash_pch7}, {0x8086, 0x1e49, B_FS, DEP, "Intel", "B75", enable_flash_pch7}, {0x8086, 0x1e4a, B_FS, DEP, "Intel", "H77", enable_flash_pch7}, {0x8086, 0x1e53, B_FS, NT, "Intel", "C216", enable_flash_pch7},
-
Angel Pons (Code Review) -
Nico Huber (Code Review)