David Hendricks has posted comments on this change. ( https://review.coreboot.org/19206 )
Change subject: Convert flashrom to git ......................................................................
Patch Set 4:
(7 comments)
I'll try to split out the complex getrevision.sh stuff in the next patch set.
https://review.coreboot.org/#/c/19206/4/Makefile File Makefile:
https://review.coreboot.org/#/c/19206/4/Makefile@a1374 PS4, Line 1374:
Why didn't I bikeshed this for being totally unrelated?
Added back in.
https://review.coreboot.org/#/c/19206/4/Makefile@1396 PS4, Line 1396: @tar -cz --format=ustar -f $(EXPORTDIR)/flashrom-$(RELEASENAME).tar.gz -C $(EXPORTDIR)/ \ : $(TAROPTIONS) flashrom-$(RELEASENAME)/ : # Delete the exported directory again because it is most likely what's expected by the user. : @rm -rf $(EXPORTDIR)/flashrom-$(RELEASENAME)
Missing quotes around everything with $(RELEASENAME).
Done
https://review.coreboot.org/#/c/19206/1/util/getrevision.sh File util/getrevision.sh:
https://review.coreboot.org/#/c/19206/1/util/getrevision.sh@66 PS1, Line 66: "to the commit history from an upstream repository. If no git remote"\
Looks good, but did you test it? Using echo this way there shouldn't be any
Obviously not, heh...
Going back to the original formatting, more or less, with shorter lines and line breaks.
It's still a lot of text, but at least now it's broken apart so each explanation and suggested action is clear. Here's how it looks in all three cases now, assuming Gerrit doesn't botch it...
-------------
To produce useful version information the build process needs access to the commit history from an upstream repository. If no git remote is pointing to one we can store the necessary information out of sight and update it on every build.
To enable this functionality and fetch the upstream commits from https://review.coreboot.org/flashrom.git please execute the following: git config flashrom.offline-builds false
Alternatively, add one of the upstream repositories as a git remote to rely on that information.
If you want to work completely offline and generate possibly meaningless version strings then disable it using: git config flashrom.offline-builds true
You can force updating the local commit cache using: ./util/getrevision.sh --force-update-upcache
---------------
Fetching commit history from upstream repository: https://review.coreboot.org/flashrom.git
To disable any network activity execute: git config flashrom.offline-builds true
---------------
Fetching commit history from upstream is disabled - version strings might be misleading.
To ensure proper version strings and allow network access execute: git config flashrom.offline-builds false
https://review.coreboot.org/#/c/19206/1/util/getrevision.sh@69 PS1, Line 69:
Why not? The message should draw the user's attention and isn't
Makes sense. Added the redirection back in.
https://review.coreboot.org/#/c/19206/1/util/getrevision.sh@269 PS1, Line 269:
Then we don't need the `if`.
Done
https://review.coreboot.org/#/c/19206/4/util/getrevision.sh File util/getrevision.sh:
https://review.coreboot.org/#/c/19206/4/util/getrevision.sh@72 PS4, Line 72: "$upstream_url"\
Maybe indent it a little.
Done
https://review.coreboot.org/#/c/19206/1/util/git-hooks/pre-push File util/git-hooks/pre-push:
https://review.coreboot.org/#/c/19206/1/util/git-hooks/pre-push@53 PS1, Line 53: "$commit" ]; then
Sounds better but is not what I meant: Both have to be present.
I reworded this to try and make it less confusing. LMK what you think.
-
David Hendricks (Code Review)