Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/38321 )
Change subject: Review access change ......................................................................
Review access change
Change-Id: I91f942850335487436433fc937627271870dcaa5 --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/38321/1
diff --git a/project.config b/project.config index a11f362..e3b7a6d 100644 --- a/project.config +++ b/project.config @@ -48,6 +48,8 @@ delete = group user/Nico Huber (Nico) delete = group user/Stefan T (stefanct) submit = group flashrom developers + label-Code-Review = -2..+2 group flashrom developers + label-Verified = -1..+1 group flashrom developers [access "refs/for/refs/heads/stable"] exclusiveGroupPermissions = push [project]
Nico Huber has uploaded a new patch set (#2). ( https://review.coreboot.org/c/flashrom/+/38321 )
Change subject: Extend prviliges of "flashrom developers" group ......................................................................
Extend prviliges of "flashrom developers" group
Allow all "flashrom developers" to give Code-Review -2/+2 and Verified -1/+1.
Change-Id: I91f942850335487436433fc937627271870dcaa5 --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/38321/2
Hello Stefan T, David Hendricks,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/38321
to look at the new patch set (#3).
Change subject: Extend privileges of "flashrom developers" group ......................................................................
Extend privileges of "flashrom developers" group
Allow all "flashrom developers" to give Code-Review -2/+2 and Verified -1/+1 for code changes.
Change-Id: I91f942850335487436433fc937627271870dcaa5 --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/21/38321/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38321 )
Change subject: Extend privileges of "flashrom developers" group ......................................................................
Patch Set 3:
Any updates? I can't even give a +1, so I'll just say it out loud.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38321 )
Change subject: Extend privileges of "flashrom developers" group ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/38321 )
Change subject: Extend privileges of "flashrom developers" group ......................................................................
Patch Set 3: Verified+1
Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/38321 )
Change subject: Extend privileges of "flashrom developers" group ......................................................................
Extend privileges of "flashrom developers" group
Allow all "flashrom developers" to give Code-Review -2/+2 and Verified -1/+1 for code changes.
Change-Id: I91f942850335487436433fc937627271870dcaa5 Reviewed-on: https://review.coreboot.org/c/flashrom/+/38321 Reviewed-by: David Hendricks david.hendricks@gmail.com Tested-by: Nico Huber nico.h@gmx.de --- M project.config 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: Nico Huber: Verified David Hendricks: Looks good to me, approved
diff --git a/project.config b/project.config index a11f362..e3b7a6d 100644 --- a/project.config +++ b/project.config @@ -48,6 +48,8 @@ delete = group user/Nico Huber (Nico) delete = group user/Stefan T (stefanct) submit = group flashrom developers + label-Code-Review = -2..+2 group flashrom developers + label-Verified = -1..+1 group flashrom developers [access "refs/for/refs/heads/stable"] exclusiveGroupPermissions = push [project]
-
Angel Pons (Code Review) -
David Hendricks (Code Review)
-
Nico Huber (Code Review)