Change in flashrom[staging]: ich_descriptors: Fix more odd +1s - flashrom-gerrit

17 Jun 2017


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/19044 )
Change subject: ich_descriptors: Fix more odd +1s
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/#/c/19044/3/ich_descriptors.c
File ich_descriptors.c:
https://review.coreboot.org/#/c/19044/3/ich_descriptors.c@a620
PS3, Line 620:
...
Just realized that I killed this whitespace by accident.
Done
https://review.coreboot.org/#/c/19044/3/ich_descriptors.c@619
PS3, Line 619:  + 1
...
This seems off, too.
Done
https://review.coreboot.org/#/c/19044/3/ich_descriptors.c@619
PS3, Line 619: sizeof(desc->north.STRPs) / 4
...
Isn't it just ARRAY_SIZE()?
Done
-- 
To view, visit https://review.coreboot.org/19044
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa5455c999e90ff9121aed29f542d71ac9ca2b1c
Gerrit-Change-Number: 19044
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Jun 2017 01:19:54 +0000
Gerrit-HasComments: Yes