Attention is currently required from: Stefan Reinauer.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49741 )
Change subject: helpers.c: Fix undefined behavior in strndup()
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49741/comment/d9fae29e_25c98017
PS1, Line 7: helpers.c: optimize strndup
About adding a unit-test for this function: Maybe, but it is only used for MinGW. […]
I don't know how to write effective test code
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49741
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id34127024085879228626fbad59af03268ec5255
Gerrit-Change-Number: 49741
Gerrit-PatchSet: 2
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 24 Jan 2021 06:20:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xiang Wang
merle@hardenedlinux.org
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment