Change in flashrom[master]: ichspi.c: Check SPI Cycle In-Progress prior start HW Seq

[Rizwan Qureshi (Code Review)]

Attention is currently required from: Patrick Georgi, Stefan Reinauer, Sridhar Siricilla, Angel Pons, Alex Levin, YH Lin, Nico Huber, Martin Roth, Subrata Banik, Caveh Jalali, Tim Wawrzynczak, Nick Vaccaro, Boris Mittelberg.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61854 )

Change subject: ichspi.c: Check SPI Cycle In-Progress prior start HW Seq
......................................................................

Patch Set 6:

(1 comment)

Patchset:

PS6:
> > > > So, if this code change is considered a missed step in HW sequencing recommendation, then this […]
>
> A version of this change that takes the applicable context into account

(e.g. other waiting loops in this driver, implications when multiple
instances would reach this point in the code simultaneously) would be
accepted immediately.

I understand that would be a comprehensive fix across flashrom. However that will still not guarantee that another flashrom like program will wait on the same file/mutex to synchronize the access.

This check on H_SCIP OTOH, which should be adhered by all the programs at the least prevents the program from cancelling out another's transaction. So let us make flashrom compliant with the recommendation.