Change in flashrom[master]: cli_classic: Use flashrom_init() from API - flashrom-gerrit

23 Feb 2022


      Attention is currently required from: Edward O'Callaghan, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61582 )
Change subject: cli_classic: Use flashrom_init() from API
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/61582/comment/e039f296_6c1fcac8 
PS4, Line 353: 	/* FIXME: Delay calibration should happen in programmer code. */
Would be much less confusing if moved into flashrom_init(). But I'm
also not sure if it still applies.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/61582
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I07faeed876f678c35355621a080c7852eed16824
Gerrit-Change-Number: 61582
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 23 Feb 2022 22:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment