Attention is currently required from: Sam McNally, Nico Huber, Stefan Reinauer.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49599 )
Change subject: flashrom.c: automatic generated programmer_enum.h
......................................................................
Patch Set 6:
(1 comment)
File Makefile:
https://review.coreboot.org/c/flashrom/+/49599/comment/9a980303_92ebea9a
PS4, Line 681: $(shell bash ./util/generator_programmer_enum.sh)
It's as I feared: If you run `make` two times in a row without this […]
Please guide me how to modify the Makefile, and meson.build also needs to make the same modification.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49599
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3f4370ccae2b64da3c4178243b192700d3d205d2
Gerrit-Change-Number: 49599
Gerrit-PatchSet: 6
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sam McNally
sammc@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Sam McNally
sammc@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Sun, 28 Mar 2021 01:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Xiang Wang
merle@hardenedlinux.org
Gerrit-MessageType: comment