Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Georg Gottleuber has posted comments on this change by Georg Gottleuber. ( https://review.coreboot.org/c/flashrom/+/82101?usp=email )
Change subject: flashchips.c: Add support for XM25RU256C ......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
Is this for 4K sector? You can add it to the array of block_erasers, next to existing SPI_BLOCK_ERAS […]
Yes it is also for 4KB sectors. This mode is similar to SPI_BLOCK_ERASE_20 but uses 32-bit address instead of 24-bit address. At the moment I have no access to a XM25RU256C chip. Therefore I leave it.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/82101/comment/8254491f_411d5dd2?usp... : PS3, Line 22118: TEST_UNTESTED
This probably slipped from a previous version of the patch? You already changed tested status to `TE […]
Done
-
Georg Gottleuber (Code Review)