Change in flashrom[master]: ni845x_spi: Fix signed - unsigned comparisons - flashrom-gerrit

27 Jul 2021


      Attention is currently required from: Nico Huber, Miklós Márton.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56637 )
Change subject: ni845x_spi: Fix signed - unsigned comparisons
......................................................................
Patch Set 1:
(1 comment)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/56637/comment/48704037_4085d45b 
PS1, Line 556: CS_number = CS_str[0] - '0';
This line converts string to number, but only two lines below the condition is checked whether the string is valid for conversion.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/56637
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I48ef927aa28433fb0e3b3a1f3fb2e797095e53bd
Gerrit-Change-Number: 56637
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Comment-Date: Tue, 27 Jul 2021 23:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment